Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: content/renderer/pepper/renderer_ppapi_host_impl.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/ppb_widget_impl.h ('k') | content/renderer/pepper/resource_converter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/renderer_ppapi_host_impl.h
diff --git a/content/renderer/pepper/renderer_ppapi_host_impl.h b/content/renderer/pepper/renderer_ppapi_host_impl.h
index dbca882680dce1b7b39e8780286be7b998bd32b2..f8f7aac540208d29ad3c8997a7fc6995d5fd39a2 100644
--- a/content/renderer/pepper/renderer_ppapi_host_impl.h
+++ b/content/renderer/pepper/renderer_ppapi_host_impl.h
@@ -36,7 +36,7 @@ class PluginModule;
// This class is attached to a PluginModule which manages our lifetime.
class RendererPpapiHostImpl : public RendererPpapiHost {
public:
- virtual ~RendererPpapiHostImpl();
+ ~RendererPpapiHostImpl() override;
// Factory functions to create in process or out-of-process host impls. The
// host will be created and associated with the given module, which must not
@@ -76,34 +76,30 @@ class RendererPpapiHostImpl : public RendererPpapiHost {
bool IsExternalPluginHost() const;
// RendererPpapiHost implementation.
- virtual ppapi::host::PpapiHost* GetPpapiHost() override;
- virtual bool IsValidInstance(PP_Instance instance) const override;
- virtual PepperPluginInstance* GetPluginInstance(PP_Instance instance) const
- override;
- virtual RenderFrame* GetRenderFrameForInstance(PP_Instance instance) const
- override;
- virtual RenderView* GetRenderViewForInstance(PP_Instance instance) const
- override;
- virtual blink::WebPluginContainer* GetContainerForInstance(
+ ppapi::host::PpapiHost* GetPpapiHost() override;
+ bool IsValidInstance(PP_Instance instance) const override;
+ PepperPluginInstance* GetPluginInstance(PP_Instance instance) const override;
+ RenderFrame* GetRenderFrameForInstance(PP_Instance instance) const override;
+ RenderView* GetRenderViewForInstance(PP_Instance instance) const override;
+ blink::WebPluginContainer* GetContainerForInstance(
PP_Instance instance) const override;
- virtual base::ProcessId GetPluginPID() const override;
- virtual bool HasUserGesture(PP_Instance instance) const override;
- virtual int GetRoutingIDForWidget(PP_Instance instance) const override;
- virtual gfx::Point PluginPointToRenderFrame(PP_Instance instance,
- const gfx::Point& pt) const
- override;
- virtual IPC::PlatformFileForTransit ShareHandleWithRemote(
+ base::ProcessId GetPluginPID() const override;
+ bool HasUserGesture(PP_Instance instance) const override;
+ int GetRoutingIDForWidget(PP_Instance instance) const override;
+ gfx::Point PluginPointToRenderFrame(PP_Instance instance,
+ const gfx::Point& pt) const override;
+ IPC::PlatformFileForTransit ShareHandleWithRemote(
base::PlatformFile handle,
bool should_close_source) override;
- virtual bool IsRunningInProcess() const override;
- virtual std::string GetPluginName() const override;
- virtual void SetToExternalPluginHost() override;
- virtual void CreateBrowserResourceHosts(
+ bool IsRunningInProcess() const override;
+ std::string GetPluginName() const override;
+ void SetToExternalPluginHost() override;
+ void CreateBrowserResourceHosts(
PP_Instance instance,
const std::vector<IPC::Message>& nested_msgs,
- const base::Callback<void(const std::vector<int>&)>& callback) const
- override;
- virtual GURL GetDocumentURL(PP_Instance instance) const override;
+ const base::Callback<void(const std::vector<int>&)>& callback)
+ const override;
+ GURL GetDocumentURL(PP_Instance instance) const override;
private:
RendererPpapiHostImpl(PluginModule* module,
« no previous file with comments | « content/renderer/pepper/ppb_widget_impl.h ('k') | content/renderer/pepper/resource_converter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698