Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: content/renderer/pepper/plugin_object.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/pepper_websocket_host.h ('k') | content/renderer/pepper/ppb_audio_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/plugin_object.h
diff --git a/content/renderer/pepper/plugin_object.h b/content/renderer/pepper/plugin_object.h
index 32860a6591b9a29a400760f2291c944c88d4d123..4dec6205d5830f14d31d0b2a93de95f291716e62 100644
--- a/content/renderer/pepper/plugin_object.h
+++ b/content/renderer/pepper/plugin_object.h
@@ -32,7 +32,7 @@ class PluginObject : public gin::Wrappable<PluginObject>,
public:
static gin::WrapperInfo kWrapperInfo;
- virtual ~PluginObject();
+ ~PluginObject() override;
// Returns the PluginObject which is contained in the given v8 object, or NULL
// if the object isn't backed by a PluginObject.
@@ -46,13 +46,12 @@ class PluginObject : public gin::Wrappable<PluginObject>,
void* ppp_class_data);
// gin::NamedPropertyInterceptor
- virtual v8::Local<v8::Value> GetNamedProperty(
- v8::Isolate* isolate,
- const std::string& property) override;
- virtual bool SetNamedProperty(v8::Isolate* isolate,
- const std::string& property,
- v8::Local<v8::Value> value) override;
- virtual std::vector<std::string> EnumerateNamedProperties(
+ v8::Local<v8::Value> GetNamedProperty(v8::Isolate* isolate,
+ const std::string& property) override;
+ bool SetNamedProperty(v8::Isolate* isolate,
+ const std::string& property,
+ v8::Local<v8::Value> value) override;
+ std::vector<std::string> EnumerateNamedProperties(
v8::Isolate* isolate) override;
const PPP_Class_Deprecated* ppp_class() { return ppp_class_; }
@@ -67,7 +66,7 @@ class PluginObject : public gin::Wrappable<PluginObject>,
void* ppp_class_data);
// gin::Wrappable
- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override;
// Helper method to get named properties.
« no previous file with comments | « content/renderer/pepper/pepper_websocket_host.h ('k') | content/renderer/pepper/ppb_audio_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698