content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/pepper_plugin_instance_impl.h ('k') | content/renderer/pepper/pepper_proxy_channel_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index ee9295d378830c35e3d81cf4f97420a28bd293a1..97a85c90f253966dd8e964bd7232cfe7d199e90f 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -356,14 +356,13 @@ class PluginInstanceLockTarget : public MouseLockDispatcher::LockTarget {

PluginInstanceLockTarget(PepperPluginInstanceImpl* plugin)

: plugin_(plugin) {}

- virtual void OnLockMouseACK(bool succeeded) override {

+ void OnLockMouseACK(bool succeeded) override {

plugin_->OnLockMouseACK(succeeded);

}

- virtual void OnMouseLockLost() override { plugin_->OnMouseLockLost(); }

+ void OnMouseLockLost() override { plugin_->OnMouseLockLost(); }

- virtual bool HandleMouseLockedInputEvent(const blink::WebMouseEvent& event)

- override {

+ bool HandleMouseLockedInputEvent(const blink::WebMouseEvent& event) override {

plugin_->HandleMouseLockedInputEvent(event);

return true;

}