content/renderer/pepper/pepper_in_process_router.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_in_process_router.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/pepper_in_process_resource_creation.h ('k') | content/renderer/pepper/pepper_media_device_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_in_process_router.cc

diff --git a/content/renderer/pepper/pepper_in_process_router.cc b/content/renderer/pepper/pepper_in_process_router.cc

index 5b0d36fef247644a6d731632524ee3d1dfcc6326..b6fd7b4e23e542e0b1a65fceed2e54fdeaf2b39f 100644

--- a/content/renderer/pepper/pepper_in_process_router.cc

+++ b/content/renderer/pepper/pepper_in_process_router.cc

@@ -24,11 +24,9 @@ class PepperInProcessRouter::Channel : public IPC::Sender {

Channel(const base::Callback<bool(IPC::Message*)>& callback)

: callback_(callback) {}

- virtual ~Channel() {}

+ ~Channel() override {}

- virtual bool Send(IPC::Message* message) override {

- return callback_.Run(message);

- }

+ bool Send(IPC::Message* message) override { return callback_.Run(message); }

private:

base::Callback<bool(IPC::Message*)> callback_;