Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: content/renderer/media/webrtc_audio_renderer.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_audio_renderer.h
diff --git a/content/renderer/media/webrtc_audio_renderer.h b/content/renderer/media/webrtc_audio_renderer.h
index 08140bbd4bcf128ba1b322201e1d36f5a6237e1e..119853472b64f6e0b1174a07349b34319c48bfdb 100644
--- a/content/renderer/media/webrtc_audio_renderer.h
+++ b/content/renderer/media/webrtc_audio_renderer.h
@@ -105,13 +105,13 @@ class CONTENT_EXPORT WebRtcAudioRenderer
// MediaStreamAudioRenderer implementation. This is private since we want
// callers to use proxy objects.
// TODO(tommi): Make the MediaStreamAudioRenderer implementation a pimpl?
- virtual void Start() override;
- virtual void Play() override;
- virtual void Pause() override;
- virtual void Stop() override;
- virtual void SetVolume(float volume) override;
- virtual base::TimeDelta GetCurrentRenderTime() const override;
- virtual bool IsLocalRenderer() const override;
+ void Start() override;
+ void Play() override;
+ void Pause() override;
+ void Stop() override;
+ void SetVolume(float volume) override;
+ base::TimeDelta GetCurrentRenderTime() const override;
+ bool IsLocalRenderer() const override;
// Called when an audio renderer, either the main or a proxy, starts playing.
// Here we maintain a reference count of how many renderers are currently
@@ -124,7 +124,7 @@ class CONTENT_EXPORT WebRtcAudioRenderer
void EnterPauseState();
protected:
- virtual ~WebRtcAudioRenderer();
+ ~WebRtcAudioRenderer() override;
private:
enum State {
@@ -149,9 +149,8 @@ class CONTENT_EXPORT WebRtcAudioRenderer
// media::AudioRendererSink::RenderCallback implementation.
// These two methods are called on the AudioOutputDevice worker thread.
- virtual int Render(media::AudioBus* audio_bus,
- int audio_delay_milliseconds) override;
- virtual void OnRenderError() override;
+ int Render(media::AudioBus* audio_bus, int audio_delay_milliseconds) override;
+ void OnRenderError() override;
// Called by AudioPullFifo when more data is necessary.
// This method is called on the AudioOutputDevice worker thread.
« no previous file with comments | « content/renderer/media/webrtc_audio_device_not_impl.h ('k') | content/renderer/media/webrtc_audio_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698