content/renderer/media/webrtc/webrtc_media_stream_adapter.h - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/webrtc_media_stream_adapter.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h ('k') | content/renderer/media/webrtc/webrtc_video_capturer_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/webrtc_media_stream_adapter.h

diff --git a/content/renderer/media/webrtc/webrtc_media_stream_adapter.h b/content/renderer/media/webrtc/webrtc_media_stream_adapter.h

index 6afa1c82e4f533963004ec0ab945da75d31a07b8..ff3ff336f910de6ef45717c55229f8b9cd6814cd 100644

--- a/content/renderer/media/webrtc/webrtc_media_stream_adapter.h

+++ b/content/renderer/media/webrtc/webrtc_media_stream_adapter.h

@@ -31,7 +31,7 @@ class CONTENT_EXPORT WebRtcMediaStreamAdapter

public:

WebRtcMediaStreamAdapter(const blink::WebMediaStream& web_stream,

PeerConnectionDependencyFactory* factory);

- virtual ~WebRtcMediaStreamAdapter();

+ ~WebRtcMediaStreamAdapter() override;

bool IsEqual(const blink::WebMediaStream& web_stream) {

return web_stream_.extraData() == web_stream.extraData();

@@ -43,8 +43,8 @@ class CONTENT_EXPORT WebRtcMediaStreamAdapter

protected:

// MediaStreamObserver implementation.

- virtual void TrackAdded(const blink::WebMediaStreamTrack& track) override;

- virtual void TrackRemoved(const blink::WebMediaStreamTrack& track) override;

+ void TrackAdded(const blink::WebMediaStreamTrack& track) override;

+ void TrackRemoved(const blink::WebMediaStreamTrack& track) override;

private:

void CreateAudioTrack(const blink::WebMediaStreamTrack& track);