content/renderer/media/webrtc/webrtc_audio_sink_adapter.h - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/webrtc_audio_sink_adapter.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/video_destination_handler.h ('k') | content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/webrtc_audio_sink_adapter.h

diff --git a/content/renderer/media/webrtc/webrtc_audio_sink_adapter.h b/content/renderer/media/webrtc/webrtc_audio_sink_adapter.h

index d0cc777d1eb229e2a848a0ad0810731db90b882d..91d8fa1e8f676e2a1f8a693f1d2c13f2d711f6a0 100644

--- a/content/renderer/media/webrtc/webrtc_audio_sink_adapter.h

+++ b/content/renderer/media/webrtc/webrtc_audio_sink_adapter.h

@@ -23,17 +23,17 @@ class WebRtcAudioSinkAdapter : public MediaStreamAudioSink {

public:

explicit WebRtcAudioSinkAdapter(

webrtc::AudioTrackSinkInterface* sink);

- virtual ~WebRtcAudioSinkAdapter();

+ ~WebRtcAudioSinkAdapter() override;

bool IsEqual(const webrtc::AudioTrackSinkInterface* other) const;

private:

// MediaStreamAudioSink implementation.

- virtual void OnData(const int16* audio_data,

- int sample_rate,

- int number_of_channels,

- int number_of_frames) override;

- virtual void OnSetFormat(const media::AudioParameters& params) override;

+ void OnData(const int16* audio_data,

+ int sample_rate,

+ int number_of_channels,

+ int number_of_frames) override;

+ void OnSetFormat(const media::AudioParameters& params) override;

webrtc::AudioTrackSinkInterface* const sink_;