content/renderer/media/webrtc/peer_connection_dependency_factory.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.h ('k') | content/renderer/media/webrtc/video_destination_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

index c43f680c056c248a73623221679524386807d7e8..33406f213753dde260dfe8df97fc86a47d36a671 100644

--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

@@ -123,7 +123,7 @@ class P2PPortAllocatorFactory : public webrtc::PortAllocatorFactoryInterface {

socket_factory_(socket_factory) {

}

- virtual cricket::PortAllocator* CreatePortAllocator(

+ cricket::PortAllocator* CreatePortAllocator(

const std::vector<StunConfiguration>& stun_servers,

const std::vector<TurnConfiguration>& turn_configurations) override {

P2PPortAllocator::Config config;

@@ -153,7 +153,7 @@ class P2PPortAllocatorFactory : public webrtc::PortAllocatorFactoryInterface {

}

protected:

- virtual ~P2PPortAllocatorFactory() {}

+ ~P2PPortAllocatorFactory() override {}

private:

scoped_refptr<P2PSocketDispatcher> socket_dispatcher_;