content/renderer/media/native_handle_impl.h - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/native_handle_impl.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/mock_peer_connection_impl.cc ('k') | content/renderer/media/peer_connection_audio_sink_owner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/native_handle_impl.h

diff --git a/content/renderer/media/native_handle_impl.h b/content/renderer/media/native_handle_impl.h

index 7b5748b681145c314fc9b53de52ca4d0395f09b9..20a4f038c6f268b969dbddd833a35941a870cb9e 100644

--- a/content/renderer/media/native_handle_impl.h

+++ b/content/renderer/media/native_handle_impl.h

@@ -15,11 +15,11 @@ class NativeHandleImpl : public webrtc::NativeHandle {

public:

// Wraps a video frame in the handle.

explicit NativeHandleImpl(scoped_refptr<media::VideoFrame> frame);

- virtual ~NativeHandleImpl();

+ ~NativeHandleImpl() override;

// Retrieves the video frame in the handle. The frame is still ref-counted by

// the handle. The ref count decreases when NativeHandleImpl is destroyed.

- virtual void* GetHandle() override;

+ void* GetHandle() override;

private:

scoped_refptr<media::VideoFrame> frame_;

« no previous file with comments | « content/renderer/media/mock_peer_connection_impl.cc ('k') | content/renderer/media/peer_connection_audio_sink_owner.h » ('j') | no next file with comments »