Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Unified Diff: content/renderer/gpu/frame_swap_message_queue.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/frame_swap_message_queue.cc
diff --git a/content/renderer/gpu/frame_swap_message_queue.cc b/content/renderer/gpu/frame_swap_message_queue.cc
index e48daa8a11beb219e2c99e42201716446f38085e..bf91dd84e0f89bdb19c8cb50922547114c474da6 100644
--- a/content/renderer/gpu/frame_swap_message_queue.cc
+++ b/content/renderer/gpu/frame_swap_message_queue.cc
@@ -36,7 +36,7 @@ namespace {
class SendMessageScopeImpl : public FrameSwapMessageQueue::SendMessageScope {
public:
SendMessageScopeImpl(base::Lock* lock) : auto_lock_(*lock) {}
- virtual ~SendMessageScopeImpl() override {}
+ ~SendMessageScopeImpl() override {}
private:
base::AutoLock auto_lock_;
@@ -46,26 +46,26 @@ class VisualStateQueue : public FrameSwapMessageSubQueue {
public:
VisualStateQueue() {}
- virtual ~VisualStateQueue() {
+ ~VisualStateQueue() override {
for (VisualStateQueueMap::iterator i = queue_.begin(); i != queue_.end();
i++) {
STLDeleteElements(&i->second);
}
}
- virtual bool Empty() const override { return queue_.empty(); }
+ bool Empty() const override { return queue_.empty(); }
- virtual void QueueMessage(int source_frame_number,
- scoped_ptr<IPC::Message> msg,
- bool* is_first) override {
+ void QueueMessage(int source_frame_number,
+ scoped_ptr<IPC::Message> msg,
+ bool* is_first) override {
if (is_first)
*is_first = (queue_.count(source_frame_number) == 0);
queue_[source_frame_number].push_back(msg.release());
}
- virtual void DrainMessages(int source_frame_number,
- ScopedVector<IPC::Message>* messages) override {
+ void DrainMessages(int source_frame_number,
+ ScopedVector<IPC::Message>* messages) override {
VisualStateQueueMap::iterator end = queue_.upper_bound(source_frame_number);
for (VisualStateQueueMap::iterator i = queue_.begin(); i != end; i++) {
DCHECK(i->first <= source_frame_number);
@@ -86,18 +86,18 @@ class VisualStateQueue : public FrameSwapMessageSubQueue {
class SwapQueue : public FrameSwapMessageSubQueue {
public:
SwapQueue() {}
- virtual bool Empty() const override { return queue_.empty(); }
+ bool Empty() const override { return queue_.empty(); }
- virtual void QueueMessage(int source_frame_number,
- scoped_ptr<IPC::Message> msg,
- bool* is_first) override {
+ void QueueMessage(int source_frame_number,
+ scoped_ptr<IPC::Message> msg,
+ bool* is_first) override {
if (is_first)
*is_first = Empty();
queue_.push_back(msg.release());
}
- virtual void DrainMessages(int source_frame_number,
- ScopedVector<IPC::Message>* messages) override {
+ void DrainMessages(int source_frame_number,
+ ScopedVector<IPC::Message>* messages) override {
messages->insert(messages->end(), queue_.begin(), queue_.end());
queue_.weak_clear();
}
« no previous file with comments | « content/renderer/gpu/delegated_compositor_output_surface.h ('k') | content/renderer/gpu/frame_swap_message_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698