content/renderer/device_sensors/device_orientation_event_pump.h - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/device_sensors/device_orientation_event_pump.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/device_sensors/device_motion_event_pump_unittest.cc ('k') | content/renderer/device_sensors/device_orientation_event_pump_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/device_sensors/device_orientation_event_pump.h

diff --git a/content/renderer/device_sensors/device_orientation_event_pump.h b/content/renderer/device_sensors/device_orientation_event_pump.h

index 43e566d26489954570454a3e6b03d9e154a08a8f..d9564e17cd048ae4eaa1b819f1763a8c3f9d4cff 100644

--- a/content/renderer/device_sensors/device_orientation_event_pump.h

+++ b/content/renderer/device_sensors/device_orientation_event_pump.h

@@ -27,19 +27,19 @@ class CONTENT_EXPORT DeviceOrientationEventPump

static const double kOrientationThreshold;

explicit DeviceOrientationEventPump(RenderThread* thread);

- virtual ~DeviceOrientationEventPump();

+ ~DeviceOrientationEventPump() override;

// PlatformEventObserver.

- virtual bool OnControlMessageReceived(const IPC::Message& message) override;

- virtual void SendFakeDataForTesting(void* data) override;

+ bool OnControlMessageReceived(const IPC::Message& message) override;

+ void SendFakeDataForTesting(void* data) override;

protected:

- virtual void FireEvent() override;

- virtual bool InitializeReader(base::SharedMemoryHandle handle) override;

+ void FireEvent() override;

+ bool InitializeReader(base::SharedMemoryHandle handle) override;

// PlatformEventObserver.

- virtual void SendStartMessage() override;

- virtual void SendStopMessage() override;

+ void SendStartMessage() override;

+ void SendStopMessage() override;

bool ShouldFireEvent(const blink::WebDeviceOrientationData& data) const;