content/renderer/device_sensors/device_light_event_pump_unittest.cc - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/device_sensors/device_light_event_pump_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/device_sensors/device_light_event_pump.h ('k') | content/renderer/device_sensors/device_motion_event_pump.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/device_sensors/device_light_event_pump_unittest.cc

diff --git a/content/renderer/device_sensors/device_light_event_pump_unittest.cc b/content/renderer/device_sensors/device_light_event_pump_unittest.cc

index f6eec3d05f0fb1d80d7788417890141407714add..59569f526e2cb7e4a139dc7a45e9d23718f1cad6 100644

--- a/content/renderer/device_sensors/device_light_event_pump_unittest.cc

+++ b/content/renderer/device_sensors/device_light_event_pump_unittest.cc

@@ -41,14 +41,14 @@ class DeviceLightEventPumpForTesting : public DeviceLightEventPump {

public:

DeviceLightEventPumpForTesting()

: DeviceLightEventPump(0) {}

- virtual ~DeviceLightEventPumpForTesting() {}

+ ~DeviceLightEventPumpForTesting() override {}

void OnDidStart(base::SharedMemoryHandle renderer_handle) {

DeviceLightEventPump::OnDidStart(renderer_handle);

}

- virtual void SendStartMessage() override { }

- virtual void SendStopMessage() override { }

- virtual void FireEvent() override {

+ void SendStartMessage() override {}

+ void SendStopMessage() override {}

+ void FireEvent() override {

DeviceLightEventPump::FireEvent();

Stop();

base::MessageLoop::current()->QuitWhenIdle();