Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: content/renderer/gpu/frame_swap_message_queue_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/frame_swap_message_queue.h" 5 #include "content/renderer/gpu/frame_swap_message_queue.h"
6 #include "ipc/ipc_message.h" 6 #include "ipc/ipc_message.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace content { 9 namespace content {
10 10
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 248
249 DrainMessages(1, &messages); 249 DrainMessages(1, &messages);
250 ASSERT_EQ(1u, messages.size()); 250 ASSERT_EQ(1u, messages.size());
251 ASSERT_TRUE(HasMessageForId(messages, first_message_.routing_id())); 251 ASSERT_TRUE(HasMessageForId(messages, first_message_.routing_id()));
252 } 252 }
253 253
254 class NotifiesDeletionMessage : public IPC::Message { 254 class NotifiesDeletionMessage : public IPC::Message {
255 public: 255 public:
256 NotifiesDeletionMessage(bool* deleted, const IPC::Message& other) 256 NotifiesDeletionMessage(bool* deleted, const IPC::Message& other)
257 : IPC::Message(other), deleted_(deleted) {} 257 : IPC::Message(other), deleted_(deleted) {}
258 virtual ~NotifiesDeletionMessage() { *deleted_ = true; } 258 ~NotifiesDeletionMessage() override { *deleted_ = true; }
259 259
260 private: 260 private:
261 bool* deleted_; 261 bool* deleted_;
262 }; 262 };
263 263
264 TEST_F(FrameSwapMessageQueueTest, TestDeletesNextSwapMessage) { 264 TEST_F(FrameSwapMessageQueueTest, TestDeletesNextSwapMessage) {
265 bool message_deleted = false; 265 bool message_deleted = false;
266 QueueNextSwapMessage(make_scoped_ptr( 266 QueueNextSwapMessage(make_scoped_ptr(
267 new NotifiesDeletionMessage(&message_deleted, first_message_))); 267 new NotifiesDeletionMessage(&message_deleted, first_message_)));
268 queue_ = NULL; 268 queue_ = NULL;
(...skipping 13 matching lines...) Expand all
282 bool message_deleted = false; 282 bool message_deleted = false;
283 QueueVisualStateMessage(1, 283 QueueVisualStateMessage(1,
284 make_scoped_ptr(new NotifiesDeletionMessage( 284 make_scoped_ptr(new NotifiesDeletionMessage(
285 &message_deleted, first_message_))); 285 &message_deleted, first_message_)));
286 queue_->DidSwap(1); 286 queue_->DidSwap(1);
287 queue_ = NULL; 287 queue_ = NULL;
288 ASSERT_TRUE(message_deleted); 288 ASSERT_TRUE(message_deleted);
289 } 289 }
290 290
291 } // namespace content 291 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue.cc ('k') | content/renderer/gpu/gpu_benchmarking_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698