Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 670683002: Terminate worker threads before detaching main thread. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Terminate worker threads before detaching main thread. To avoid worker shutdown touching a detached main thread's heap, move up the termination of worker threads in the shutdown sequence. R=haraken,tzik BUG=414380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/core/Init.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
Please take a look. ASAN reports no trouble.
6 years, 2 months ago (2014-10-21 09:08:39 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-21 09:13:08 UTC) #3
tzik
lgtm
6 years, 2 months ago (2014-10-21 09:14:42 UTC) #4
sof
Thanks for the reviews; will wait on complete results from Oilpan bots before taking next ...
6 years, 2 months ago (2014-10-21 09:17:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670683002/1
6 years, 2 months ago (2014-10-21 11:12:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:15:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184071

Powered by Google App Engine
This is Rietveld 408576698