Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 670673002: Remove v8stdint.h, it doesn't serve a purpose anymore. (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Remove v8stdint.h, it doesn't serve a purpose anymore. Basically a follow-up to https://codereview.chromium.org/667573005/. LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24755

Patch Set 1 #

Patch Set 2 : Actually removed the header #

Patch Set 3 : Fixed Windows builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -39 lines) Patch
M include/v8.h View 1 chunk +5 lines, -1 line 0 comments Download
D include/v8stdint.h View 1 1 chunk +0 lines, -16 lines 0 comments Download
M src/assert-scope.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/atomicops.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/bits.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/functional.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/base/logging.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/macros.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/base/once.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/base/sys-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bignum-dtoa.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/cached-powers.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/diy-fp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/dtoa.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/fast-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/fixed-dtoa.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparse-data.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/preparser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/scanner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/token.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/base/division-by-constant-unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/base/flags-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/gtest-support.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-21 07:56:05 UTC) #2
Sven Panne
6 years, 2 months ago (2014-10-21 08:25:42 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 24755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698