Issue 67067: Merge 13052 - Speculative fix for a crash in resource handlers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67067: Merge 13052 - Speculative fix for a crash in resource handlers.... (Closed)

Created:
11 years, 8 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari, paulg

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/

Visibility:
Public.

Description

Merge 13052 - Speculative fix for a crash in resource handlers. Investigating the crash dumps for this bug, it looks like under certain network error conditions, the resource handlers are freed before the SafeBrowsing check has completed. When the check runs, it calls into invalid memory and crashes. BUG=8544 (http://crbug.com/8544) Review URL: http://codereview.chromium.org/60043 TBR=paulg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13560

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/safe_browsing_resource_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/safe_browsing_resource_handler.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Godavari

11 years, 8 months ago (2009-04-13 18:53:53 UTC) #2

This change won't actually fix the problem. I have a real fix in code review
right now (although it's harmless to merge your change in).

http://codereview.chromium.org/63036

Expand Messages | Collapse Messages