Prepopulate the Find box with whatever was searched for last

Once you search for something in a tab, you are very likely to search for the same thing in another tab. Therefore, if you haven't searched for anything within that tab then Chrome should prepopulate the Find box with the last string you searched for (in any tab).

BUG=876
TEST=Open google.com, Ctrl+F, search for 'e'. Open a new tab/new window/open a link in a new window. In all of those new tabs the Find box should be prepopulated with 'e' that is selected (for easy overwriting).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13613

[Finnur, 2009-04-11 16:57:35]

Oh BTW: As is probably obvious, the purpose of the find_prepopulate_text pointer
is to avoid a global static class initialization of type string16. Feels like a
bit of a pointless exercise, but whatever.

[Ben Goodger (Google), 2009-04-13 20:48:24]

http://codereview.chromium.org/67066/diff/1/4
File chrome/browser/find_bar_controller.cc (right):

http://codereview.chromium.org/67066/diff/1/4#newcode84
Line 84: find_string = web_contents_->find_prepopulate_text();
nit: indentation

http://codereview.chromium.org/67066/diff/1/3
File chrome/browser/tab_contents/web_contents.cc (right):

http://codereview.chromium.org/67066/diff/1/3#newcode239
Line 239: find_prepopulate_text_ = &global_last_search;
is there a reason to save a pointer to this rather than just making the member
static?

[Ben Goodger (Google), 2009-04-13 20:48:48]

Oh. you explained in your comment.

[Ben Goodger (Google), 2009-04-13 20:49:09]

On 2009/04/13 20:48:48, Ben Goodger wrote:
> Oh. you explained in your comment.

LGTM then.

[brettw, 2009-04-13 22:25:24]

It would be really great if this complexity didn't have to be in WebContents.
There is a lot of finding code in there that seems like it should be in a
separate component.