Issue 67064: Implement tooltips for the Go/Stop button in Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67064: Implement tooltips for the Go/Stop button in Linux. (Closed)

Created:
11 years, 8 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement tooltips for the Go/Stop button in Linux. BUG=9381

Patch Set 1 #

Patch Set 2 : Add a NULL check on location_bar_ for tests. #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -8 lines)			Patch
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/go_button_gtk.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/go_button_gtk.cc	View	1	4 chunks	+34 lines, -5 lines	0 comments	Download
M	chrome/browser/gtk/go_button_gtk_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

I apparently forgot to run my own tests. It crashes since the LocationBarViewGtk isn't there ...

11 years, 8 months ago (2009-04-13 18:20:33 UTC) #3

Elliot Glaysher

11 years, 8 months ago (2009-04-13 20:49:24 UTC) #4

Go right ahead.

On 2009/04/13 18:20:33, willchan wrote:
> I apparently forgot to run my own tests.  It crashes since the
> LocationBarViewGtk isn't there in my unit test.  I added a simple NULL check
for
> this test situation.  Let me know if this is cool with you.
> 
> On 2009/04/13 17:46:33, Elliot Glaysher wrote:
> > LGTM

Expand Messages | Collapse Messages