src/x64/full-codegen-x64.cc - Issue 670623005: Spread the knowledge!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 670623005: Spread the knowledge! (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index c078f979998946925dd166f50f4aeec3ce1562ef..90df54995f3362a0922f7cb6ff913c5deabe4773 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1691,6 +1691,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

DCHECK(!CompileTimeValue::IsCompileTimeValue(value));

// Fall through.

case ObjectLiteral::Property::COMPUTED:

+ // It is safe to use [[Put]] here because the boilerplate already

+ // contains computed properties with an uninitialized value.

if (key->value()->IsInternalizedString()) {

if (property->emit_store()) {

VisitForAccumulatorValue(value);

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »