Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 670623005: Spread the knowledge! (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Lomov (no reviews)
PTAL :)
6 years, 2 months ago (2014-10-21 17:26:26 UTC) #1
Michael Starzinger
LGTM.
6 years, 2 months ago (2014-10-21 18:35:20 UTC) #2
arv (Not doing code reviews)
LGTM
6 years, 2 months ago (2014-10-21 21:10:37 UTC) #4
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-22 08:06:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698