Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: extensions/common/manifest_handlers/options_page_info.cc

Issue 670623004: Make the default value of open-in-tab false when the options_ui key is given. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/options_page_info.cc
diff --git a/extensions/common/manifest_handlers/options_page_info.cc b/extensions/common/manifest_handlers/options_page_info.cc
index efcff839765cb21ed83b935209fdf06b7e07f84f..a8bb4d678d68e67d59c17f03f6b354ec0043b659 100644
--- a/extensions/common/manifest_handlers/options_page_info.cc
+++ b/extensions/common/manifest_handlers/options_page_info.cc
@@ -144,6 +144,7 @@ scoped_ptr<OptionsPageInfo> OptionsPageInfo::Create(
}
if (options_ui->chrome_style.get())
chrome_style = *options_ui->chrome_style;
+ open_in_tab = false;
if (options_ui->open_in_tab.get())
open_in_tab = *options_ui->open_in_tab;
}
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698