Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 670623004: Make the default value of open-in-tab false when the options_ui key is given. (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the default value of open-in-tab false when the options_ui key is given. Previously it was true to maintain consistency with the options_page key, but this introduces more complexity than it avoids for extension developers. BUG=414920 R=rockot@chromium.org Committed: https://crrev.com/496b34d93dbf9968d273e1d52f0ebb6f680a4f0c Cr-Commit-Position: refs/heads/master@{#302200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -53 lines) Patch
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 2 chunks +70 lines, -53 lines 0 comments Download
M extensions/common/manifest_handlers/options_page_info.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
6 years, 2 months ago (2014-10-21 17:15:05 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-21 18:26:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670623004/1
6 years, 1 month ago (2014-10-30 23:56:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 00:42:15 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 00:42:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/496b34d93dbf9968d273e1d52f0ebb6f680a4f0c
Cr-Commit-Position: refs/heads/master@{#302200}

Powered by Google App Engine
This is Rietveld 408576698