Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 670573005: Adding Select Action Bar Copy Unit Test cases (Closed)

Created:
6 years, 1 month ago by AKVT
Modified:
6 years, 1 month ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding Select Action Bar Copy Unit Test cases Select Action Bar is not having enough unit test coverage. This change takes care of adding required unit test case for Copy operation. Committed: https://crrev.com/72c5a2a0d6729802a43a114700d259f69fb1dc2e Cr-Commit-Position: refs/heads/master@{#301781}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comments, by reusing existing HTML elements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 4 chunks +88 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
AKVT
@jdduke PTAL
6 years, 1 month ago (2014-10-28 17:29:09 UTC) #2
jdduke (slow)
https://codereview.chromium.org/670573005/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java File content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java (right): https://codereview.chromium.org/670573005/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java#newcode41 content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:41: + "<br/><p><span id=\"simple_plain_text\">SimplePlainText</span></p>" Why can't we re-use the |plain_text_1| ...
6 years, 1 month ago (2014-10-28 17:35:41 UTC) #3
AKVT
PTAL https://codereview.chromium.org/670573005/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java File content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java (right): https://codereview.chromium.org/670573005/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java#newcode41 content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:41: + "<br/><p><span id=\"simple_plain_text\">SimplePlainText</span></p>" On 2014/10/28 17:35:41, jdduke wrote: ...
6 years, 1 month ago (2014-10-28 17:54:56 UTC) #4
jdduke (slow)
lgtm
6 years, 1 month ago (2014-10-28 19:20:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670573005/20001
6 years, 1 month ago (2014-10-29 03:05:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 03:51:15 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 03:52:08 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/72c5a2a0d6729802a43a114700d259f69fb1dc2e
Cr-Commit-Position: refs/heads/master@{#301781}

Powered by Google App Engine
This is Rietveld 408576698