Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 670533003: Version 3.28.71.17 (merged r24706, r24708) (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
Reviewers:
danno
CC:
ulan, v8-dev
Project:
v8
Visibility:
Public.

Description

Version 3.28.71.17 (merged r24706, r24708) Don't expose Array.prototype.values as it breaks webcompat Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values BUG=chromium:409858 LOG=N R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M src/array.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/array-iterator.js View 6 chunks +7 lines, -10 lines 0 comments Download
M test/mjsunit/es6/typed-array-iterator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
6 years, 2 months ago (2014-10-20 19:48:31 UTC) #1
adamk
6 years, 2 months ago (2014-10-20 19:49:53 UTC) #2
danno
lgtm
6 years, 2 months ago (2014-10-20 20:11:47 UTC) #3
adamk
6 years, 2 months ago (2014-10-20 20:15:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24747.

Powered by Google App Engine
This is Rietveld 408576698