Add color emoji fallback for distance field text.

Add color emoji fallback for distance field text.

BUG=skia:3033
Committed: https://skia.googlesource.com/skia/+/fca302ccf464933e44e00255654d27a7705abb7f

[jvanverth1, 2014-10-20 18:01:04]

jvanverth@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2014-10-20 18:52:12]

lgtm + nits & suggestions

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp
File gm/dftext.cpp (right):

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp#newcode42
gm/dftext.cpp:42: 
SK_OVERRIDE ?

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp#newcode46
gm/dftext.cpp:46: 
SK_OVERRIDE ?

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp#newcode228
gm/dftext.cpp:228: 
DEF_GM ?

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
File src/gpu/GrDistanceFieldTextContext.cpp (right):

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:318: size_t newByteLength =
text-lastText;
fallbackText.push_back_n(newByteLength, lastText);
lastText = text;

??

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:323: fallbackPos.push_back(pos[0]);
const on left ?

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:326: }
Doesn't fallbackText.count() already store this?

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:354: size_t newByteLength =
text-lastText;
push_back_n here too ?

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:359: fallbackPos.push_back(pos[0]);
const on left ?

[jvanverth1, 2014-10-20 20:04:41]

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp
File gm/dftext.cpp (right):

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp#newcode42
gm/dftext.cpp:42: 
On 2014/10/20 18:52:11, robertphillips wrote:
> SK_OVERRIDE ?

Done.

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp#newcode46
gm/dftext.cpp:46: 
On 2014/10/20 18:52:11, robertphillips wrote:
> SK_OVERRIDE ?

Done.

https://codereview.chromium.org/670533002/diff/60001/gm/dftext.cpp#newcode228
gm/dftext.cpp:228: 
On 2014/10/20 18:52:11, robertphillips wrote:
> DEF_GM ?

Done.

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
File src/gpu/GrDistanceFieldTextContext.cpp (right):

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:318: size_t newByteLength =
text-lastText;
On 2014/10/20 18:52:11, robertphillips wrote:
> fallbackText.push_back_n(newByteLength, lastText);
> lastText = text;
> 
> ??

Done.

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:323: fallbackPos.push_back(pos[0]);
On 2014/10/20 18:52:11, robertphillips wrote:
> const on left ?

Done.

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:326: }
On 2014/10/20 18:52:11, robertphillips wrote:
> Doesn't fallbackText.count() already store this?

Done.

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:354: size_t newByteLength =
text-lastText;
On 2014/10/20 18:52:11, robertphillips wrote:
> push_back_n here too ?

Done.

https://codereview.chromium.org/670533002/diff/60001/src/gpu/GrDistanceFieldT...
src/gpu/GrDistanceFieldTextContext.cpp:359: fallbackPos.push_back(pos[0]);
On 2014/10/20 18:52:11, robertphillips wrote:
> const on left ?

Done.

[jvanverth1, 2014-10-20 20:04:46]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-10-20 20:05:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670533002/80001

[commit-bot: I haz the power, 2014-10-20 20:13:13]

Committed patchset #5 (id:80001) as fca302ccf464933e44e00255654d27a7705abb7f