Issue 670483003: Remove an unnecessary reinterpret_cast from a persistent to an handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670483003: Remove an unnecessary reinterpret_cast from a persistent to an handle (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 2 months ago

Reviewers:
haraken, dcarney

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Remove an unnecessary reinterpret_cast from a persistent to an handle It's really only required for debug checks, and in debug builds, we can take the hit of creating a safe handle BUG=none R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184000

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
	M	Source/bindings/core/v8/ScriptProfiler.cpp	View		2 chunks	+14 lines, -6 lines	0 comments	Download
	M	Source/bindings/core/v8/WrapperTypeInfo.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670483003/1

6 years, 2 months ago (2014-10-20 15:07:26 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 184000

6 years, 2 months ago (2014-10-20 17:35:17 UTC) #5

Message was sent while issue was closed.

LGTM