LayoutTests/fast/multicol/column-count-with-rules-expected.html - Issue 670473002: Convert fast/multicol/column-count-with-rules (and related) to reftests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/column-count-with-rules-expected.html

Issue 670473002: Convert fast/multicol/column-count-with-rules (and related) to reftests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/multicol/column-count-with-rules.html ('K') | « LayoutTests/fast/multicol/column-count-with-rules.html ('k') | LayoutTests/fast/multicol/vertical-lr/column-count-with-rules.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .columns {

	4 position: relative;

	5 width: 340px;

	6 height: 100px;

	7 border: 10px solid maroon;

	8 margin-bottom: 1em;

	9 line-height: 20px;

	10 }

	11 .column {

	12 width: 120px;

	13 display: inline-block;
	mstensho (USE GERRIT) 2014/10/20 21:42:31 float:left instead of display:inline-block? Then t float:left instead of display:inline-block? Then there will be no need to mess with vertical alignment or worry about whitespace between the elements. andersr 2014/10/21 12:33:35 Done. Show quoted text On 2014/10/20 21:42:31, mstensho wrote: > float:left instead of display:inline-block? Then there will be no need to mess > with vertical alignment or worry about whitespace between the elements. Done.
	14 vertical-align: top;

	15 }

	16 .column:last-child {

	17 width: 100px;

	18 }

	19 .rule {

	20 height: 100px;

	21 width: 2px;

	22 background-color: black;

	23 position: absolute;
	mstensho (USE GERRIT) 2014/10/20 21:42:31 You could also do the rules as floats, of course, You could also do the rules as floats, of course, between the "columns". Might even make them as wide as the coulmn-gap, by setting "margin:0 9px", and then let the "column" elements have the correct width of 100px, instead of 120px. andersr 2014/10/21 12:33:35 Yeah, that's much better. Done. Show quoted text On 2014/10/20 21:42:31, mstensho wrote: > You could also do the rules as floats, of course, between the "columns". Might > even make them as wide as the coulmn-gap, by setting "margin:0 9px", and then > let the "column" elements have the correct width of 100px, instead of 120px. Yeah, that's much better. Done.
	24 }

	25 .rule1 { left: 109px; }

	26 .rule2 { left: 229px; }

	27 </style>

	28 <div class="columns">

	29 <div class="rule rule1"></div>

	30 <div class="rule rule2"></div>

	31 <div class="column">

	32 Column text.<br>

	33 Column text.<br>

	34 Column text.<br>

	35 Column text.<br>

	36 Column text.<br>

	37 </div><div class="column">

	38 Column text.<br>

	39 Column text.<br>

	40 Column text.<br>

	41 Column text.<br>

	42 Column text.<br>

	43 </div><div class="column">

	44 Column text.<br>

	45 Column text.<br>

	46 </div>

	47 </div>

	48

	49 <div class="columns" style="direction:rtl;">

	50 <div class="rule rule1"></div>

	51 <div class="rule rule2"></div>

	52 <div class="column">

	53 Column text.<br>

	54 Column text.<br>

	55 Column text.<br>

	56 Column text.<br>

	57 Column text.<br>

	58 </div><div class="column">

	59 Column text.<br>

	60 Column text.<br>

	61 Column text.<br>

	62 Column text.<br>

	63 Column text.<br>

	64 </div><div class="column">

	65 Column text.<br>

	66 Column text.<br>

	67 </div>

	68 </div>

OLD	NEW