Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h

Issue 670463004: Make a platform-independent ToolbarActionViewController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h
diff --git a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..b2797d17d6bc84f76ebe5cda93a9f675590d4d84
--- /dev/null
+++ b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h
@@ -0,0 +1,134 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VIEWS_H_
+
+#include "chrome/browser/ui/extensions/extension_action_platform_delegate.h"
+#include "chrome/browser/ui/views/extensions/extension_popup.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "ui/base/accelerators/accelerator.h"
+#include "ui/views/context_menu_controller.h"
+#include "ui/views/widget/widget_observer.h"
+
+class Browser;
+class ExtensionAction;
+class ToolbarActionViewDelegateViews;
+
+namespace content {
+class WebContents;
+}
+
+namespace extensions {
+class Command;
+class Extension;
+}
+
+namespace ui {
+class Accelerator;
+}
+
+namespace views {
+class MenuRunner;
+class View;
+class Widget;
+}
+
+// An abstract "View" for an ExtensionAction (either a BrowserAction or a
+// PageAction). This contains the logic for showing the action's popup and
+// the context menu. This class doesn't subclass View directly, as the
+// implementations for page actions/browser actions are different types of
+// views.
+// All common logic for executing extension actions should go in this class;
+// ToolbarActionViewDelegate classes should only have knowledge relating to
+// the views::View wrapper.
+class ExtensionActionPlatformDelegateViews
+ : public ExtensionActionPlatformDelegate,
+ public content::NotificationObserver,
+ public ui::AcceleratorTarget,
+ public views::ContextMenuController,
+ public views::WidgetObserver {
+ public:
+ ExtensionActionPlatformDelegateViews(
+ ExtensionActionViewController* controller);
+ ~ExtensionActionPlatformDelegateViews() override;
+
+ private:
+ // ExtensionActionPlatformDelegate:
+ gfx::NativeView GetPopupNativeView() override;
+ bool IsMenuRunning() const override;
+ void RegisterCommand() override;
+ void OnDelegateSet() override;
+ bool IsShowingPopup() const override;
+ void CloseActivePopup() override;
+ void CloseOwnPopup() override;
+ bool ShowPopupWithUrl(
+ ExtensionActionViewController::PopupShowAction show_action,
+ const GURL& popup_url,
+ bool grant_tab_permissions) override;
+
+ // content::NotificationObserver:
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
+
+ // ui::AcceleratorTarget:
+ bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
+ bool CanHandleAccelerators() const override;
+
+ // views::WidgetObserver:
+ void OnWidgetDestroying(views::Widget* widget) override;
+
+ // views::ContextMenuController:
+ void ShowContextMenuForView(views::View* source,
+ const gfx::Point& point,
+ ui::MenuSourceType source_type) override;
+
+ // Shows the context menu for extension action.
+ void DoShowContextMenu(ui::MenuSourceType source_type);
+
+ // Unregisters the accelerator for the extension action's command, if one
+ // exists. If |only_if_removed| is true, then this will only unregister if the
+ // command has been removed.
+ void UnregisterCommand(bool only_if_removed);
+
+ // Closes the currently-active menu, if needed. This is the case when there
+ // is an active menu that wouldn't close automatically when a new one is
+ // opened.
+ // Returns true if a menu was closed, false otherwise.
+ bool CloseActiveMenuIfNeeded();
+
+ // Cleans up after the popup. If |close_widget| is true, this will call
+ // Widget::Close() on the popup's widget; otherwise it assumes the popup is
+ // already closing.
+ void CleanupPopup(bool close_widget);
+
+ ToolbarActionViewDelegateViews* GetDelegateViews() const;
+
+ // The owning ExtensionActionViewController.
+ ExtensionActionViewController* controller_;
+
+ // Responsible for running the menu.
+ scoped_ptr<views::MenuRunner> menu_runner_;
+
+ // The browser action's popup, if it is visible; NULL otherwise.
+ ExtensionPopup* popup_;
+
+ // The extension key binding accelerator this extension action is listening
+ // for (to show the popup).
+ scoped_ptr<ui::Accelerator> action_keybinding_;
+
+ // If non-NULL, this is the next ExtensionActionViewController context menu
+ // which wants to run once the current owner (this one) is done.
+ base::Closure followup_context_menu_task_;
+
+ content::NotificationRegistrar registrar_;
+
+ base::WeakPtrFactory<ExtensionActionPlatformDelegateViews> weak_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionActionPlatformDelegateViews);
+};
+
+#endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_ACTION_PLATFORM_DELEGATE_VIEWS_H_

Powered by Google App Engine
This is Rietveld 408576698