Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc

Issue 670463004: Make a platform-independent ToolbarActionViewController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc
diff --git a/chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc b/chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc
index c46a216b8006b0c62f06120da863f39df303b154..5778d527e1dd6e0931c5f5aa686c033a1d0dcb77 100644
--- a/chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc
+++ b/chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc
@@ -36,12 +36,16 @@ class MockComponentAction : public ToolbarActionViewController {
gfx::ImageSkia GetIconWithBadge() override {
return *GetIcon(nullptr).ToImageSkia();
}
- base::string16 GetAccessibleName(
- content::WebContents* web_contents) const override {
+ base::string16 GetActionName() const override {
return base::ASCIIToUTF16("Component Action");
}
- base::string16 GetTooltip(content::WebContents* web_contents) const override {
- return GetAccessibleName(web_contents);
+ base::string16 GetAccessibleName(content::WebContents* web_contents)
+ const override {
+ return GetActionName();
+ }
+ base::string16 GetTooltip(content::WebContents* web_contents)
+ const override {
+ return GetActionName();
}
bool IsEnabled(content::WebContents* web_contents) const override {
return true;

Powered by Google App Engine
This is Rietveld 408576698