chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 670463004: Make a platform-independent ToolbarActionViewController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 670463004: Make a platform-independent ToolbarActionViewController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm ('K') | « chrome/browser/ui/cocoa/extensions/extension_popup_controller.h ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index 117114741eb717d81aed0522eb734bafbcacffa0..3004f2ded899c1183eeee37f44bab18c4bc4ef37 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -148,6 +148,8 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {

@implementation ExtensionPopupController

+@synthesize extensionId = extensionId_;

- (id)initWithHost:(extensions::ExtensionViewHost*)host

parentWindow:(NSWindow*)parentWindow

anchoredAt:(NSPoint)anchoredAt

@@ -166,6 +168,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {

parentWindow:parentWindow

anchoredAt:anchoredAt])) {

host_.reset(host);

+ extensionId_ = host_->extension_id();

beingInspected_ = devMode;

ignoreWindowDidResignKey_ = NO;