chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm - Issue 670463004: Make a platform-independent ToolbarActionViewController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 670463004: Make a platform-independent ToolbarActionViewController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('K') | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h » ('j') | chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

index 1ee16620fbc4bfbcbf402230994c5a72947159db..a9e2c5e1e5e334a66e6fee66b0594ace08b6f280 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

@@ -233,7 +233,7 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {

} else if (actionManager->GetBrowserAction(*extension_) == action_) {

BrowserActionsController* controller =

[toolbarController browserActionsController];

- popupPoint = [controller popupPointForBrowserAction:extension_];

+ popupPoint = [controller popupPointForId:extension_->id()];

} else {

NOTREACHED() << "action_ is not a page action or browser action?";

}