Issue 670433003: d8: create compile cache in a separate isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670433003: d8: create compile cache in a separate isolate. (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
5 years, 9 months ago

Reviewers:
vogelheim

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

d8: create compile cache in a separate isolate. R=vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24752

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -22 lines)			Patch
	M	src/d8.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/d8.cc	View		1 chunk	+65 lines, -22 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vogelheim

lgtm Thanks! Looks nicer this way... :) https://codereview.chromium.org/670433003/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/670433003/diff/1/src/d8.cc#newcode180 src/d8.cc:180: ScriptCompiler::CachedData* Shell::CompileCachedData( ...

6 years, 2 months ago (2014-10-20 16:27:52 UTC) #2

Yang

6 years, 2 months ago (2014-10-21 06:40:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24752 (presubmit successful).

Expand Messages | Collapse Messages