Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 670433002: DevTools: Remove unused code after service/shared worker inspection migration to main thread. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
Reviewers:
pfeldman, yurys, horo
CC:
blink-reviews, falken, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, mkwst+moarreviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Remove unused code after service/shared worker inspection migration to main thread. BUG=404355 R=yurys, pfeldman, horo Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -38 lines) Patch
M Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/core/workers/WorkerObjectProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerReportingProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M public/web/WebEmbeddedWorker.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSharedWorker.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
vsevik
PTAL This is simply removing of unused code.
6 years, 2 months ago (2014-10-20 09:37:41 UTC) #1
pfeldman
lgtm.
6 years, 2 months ago (2014-10-20 10:03:18 UTC) #2
horo
Thank you! lgtm
6 years, 2 months ago (2014-10-21 00:23:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670433002/1
6 years, 2 months ago (2014-10-21 08:01:00 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 09:07:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184056

Powered by Google App Engine
This is Rietveld 408576698