Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 670423002: Chromecast buildfix (Android): locale API changed. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast buildfix (Android): locale API changed. See: https://codereview.chromium.org/628263004 R=lcwu@chromium.org BUG=None Committed: https://crrev.com/1410111091ab82b64d7400cd8d2ee7158e920240 Cr-Commit-Position: refs/heads/master@{#300939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromecast/browser/cast_http_user_agent_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
6 years, 2 months ago (2014-10-23 19:13:44 UTC) #1
lcwu1
lgtm
6 years, 2 months ago (2014-10-23 19:15:37 UTC) #2
gunsch
On 2014/10/23 19:15:37, lcwu1 wrote: > lgtm one day, we'll have a trybot
6 years, 2 months ago (2014-10-23 19:18:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670423002/1
6 years, 2 months ago (2014-10-23 19:20:24 UTC) #5
lcwu1
On 2014/10/23 19:18:35, gunsch wrote: > On 2014/10/23 19:15:37, lcwu1 wrote: > > lgtm > ...
6 years, 2 months ago (2014-10-23 19:31:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 20:23:43 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 20:24:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1410111091ab82b64d7400cd8d2ee7158e920240
Cr-Commit-Position: refs/heads/master@{#300939}

Powered by Google App Engine
This is Rietveld 408576698