Make sure we can handle favicons that are provided as data: URLs

Make sure we can handle favicons that are provided as data: URLs

BUG=9881
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13551

[arv (Not doing code reviews), 2009-04-10 20:18:02]

Hi Scott,

Do you mind taking a look at this?

What is the policy regarding unit tests for private methods?

[sky, 2009-04-10 20:43:44]

You can use the macro FRIEND_TEST for testing private methods.

http://codereview.chromium.org/67042/diff/1009/12
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/67042/diff/1009/12#newcode2050
Line 2050: if (image.empty() && image_url.SchemeIs("data")) {
If the scheme is a data url, should we handle it in OnDownloadImage? That way we
don't have to try and download anything.

http://codereview.chromium.org/67042/diff/1009/12#newcode2075
Line 2075: // The question is whether it is worth it?
I don't think this matters.

[arv (Not doing code reviews), 2009-04-10 22:54:26]

PTAL

http://codereview.chromium.org/67042/diff/1009/12
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/67042/diff/1009/12#newcode2075
Line 2075: // The question is whether it is worth it?
On 2009/04/10 20:43:44, sky wrote:
> I don't think this matters.

I'll remove the comment.

[sky, 2009-04-10 23:08:22]

LGTM