Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: tests/CanvasTest.cpp

Issue 670403002: Reenable assertions that were reported failing in tests/CanvasTest.cpp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/CanvasTest.cpp
diff --git a/tests/CanvasTest.cpp b/tests/CanvasTest.cpp
index 3cefcbd4de8cdbc98e5ec09707a0c8a29ad58f61..9b165e4cd0f49c9cefdb5564214f1cc536f638ff 100644
--- a/tests/CanvasTest.cpp
+++ b/tests/CanvasTest.cpp
@@ -600,12 +600,6 @@ static void AssertCanvasStatesEqual(skiatest::Reporter* reporter, const TestData
canvas2->getTotalMatrix(), testStep->assertMessage());
REPORTER_ASSERT_MESSAGE(reporter, equal_clips(*canvas1, *canvas2), testStep->assertMessage());
- // The following test code is commented out because the test fails when
- // the canvas is an SkPictureRecord or SkDeferredCanvas
- // Issue: http://code.google.com/p/skia/issues/detail?id=498
- // Also, creating a LayerIter on an SkProxyCanvas crashes
- // Issue: http://code.google.com/p/skia/issues/detail?id=499
- /*
SkCanvas::LayerIter layerIter1(const_cast<SkCanvas*>(canvas1), false);
SkCanvas::LayerIter layerIter2(const_cast<SkCanvas*>(canvas2), false);
while (!layerIter1.done() && !layerIter2.done()) {
@@ -626,7 +620,7 @@ static void AssertCanvasStatesEqual(skiatest::Reporter* reporter, const TestData
testStep->assertMessage());
REPORTER_ASSERT_MESSAGE(reporter, layerIter2.done(),
testStep->assertMessage());
- */
+
}
// The following class groups static functions that need to access
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698