Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Issue 670303005: Compiling Go against C interface (Closed)

Created:
6 years, 1 month ago by stephana
Modified:
6 years, 1 month ago
Reviewers:
jcgregorio, reed1
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Quick and dirty test to call the C interface from GO. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0b5fc9774f6cf155ba4ff1a8e4e3e753206ad969

Patch Set 1 #

Patch Set 2 : Fixed import paths #

Total comments: 2

Patch Set 3 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A experimental/go-skia/skia.go View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M include/c/sk_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stephana
PTAL Our discussion reminded me that I put this together over the weekend. I tried ...
6 years, 1 month ago (2014-10-30 22:15:24 UTC) #2
tfarina
https://codereview.chromium.org/670303005/diff/20001/experimental/go-skia/skia.go File experimental/go-skia/skia.go (right): https://codereview.chromium.org/670303005/diff/20001/experimental/go-skia/skia.go#newcode30 experimental/go-skia/skia.go:30: // TODO: replace this which an idiomatic interface to ...
6 years, 1 month ago (2014-10-30 22:16:33 UTC) #3
reed1
lgtm
6 years, 1 month ago (2014-10-31 12:16:19 UTC) #5
stephana
https://codereview.chromium.org/670303005/diff/20001/experimental/go-skia/skia.go File experimental/go-skia/skia.go (right): https://codereview.chromium.org/670303005/diff/20001/experimental/go-skia/skia.go#newcode30 experimental/go-skia/skia.go:30: // TODO: replace this which an idiomatic interface to ...
6 years, 1 month ago (2014-10-31 12:18:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670303005/40001
6 years, 1 month ago (2014-10-31 12:19:09 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:11:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 0b5fc9774f6cf155ba4ff1a8e4e3e753206ad969

Powered by Google App Engine
This is Rietveld 408576698