Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 670303002: DevTools: fix Ctrl-Plus/Ctrl-Minus shortcuts for zooming in hosted mode (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix Ctrl-Plus/Ctrl-Minus shortcuts for zooming in hosted mode As action system handles global shortcuts asynchronously, it optimistically captures event to prevent the default browser action. This behavior results in unfunctioning zoom in/out shortcuts in hosted mode. The patch adds a workaround which doesn't let the action system a chance to step in and prevent default behavior for the zooming shortcuts in hosted mode. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184274

Patch Set 1 #

Patch Set 2 : renaming #

Total comments: 1

Patch Set 3 : fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Source/devtools/front_end/host/InspectorFrontendHost.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
lushnikov
ptal
6 years, 2 months ago (2014-10-23 00:25:08 UTC) #1
pfeldman
https://codereview.chromium.org/670303002/diff/20001/Source/devtools/front_end/host/InspectorFrontendHost.js File Source/devtools/front_end/host/InspectorFrontendHost.js (right): https://codereview.chromium.org/670303002/diff/20001/Source/devtools/front_end/host/InspectorFrontendHost.js#newcode308 Source/devtools/front_end/host/InspectorFrontendHost.js:308: var zoomInKey = WebInspector.KeyboardShortcut.makeKey(WebInspector.KeyboardShortcut.Keys.Plus.code, WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta); Are you absolutely sure ...
6 years, 2 months ago (2014-10-23 12:24:13 UTC) #3
pfeldman
if yes, not lgtm
6 years, 2 months ago (2014-10-23 12:24:34 UTC) #4
pfeldman
lgtm
6 years, 2 months ago (2014-10-23 12:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670303002/40001
6 years, 2 months ago (2014-10-23 12:57:55 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 15:00:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184274

Powered by Google App Engine
This is Rietveld 408576698