cc: Don't double-tick unthrottled FrameRateController

cc/scheduler/frame_rate_controller_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler/frame_rate_controller.h"
 
 #include "base/test/test_simple_task_runner.h"
 #include "cc/test/scheduler_test_common.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 namespace {
 
 class FakeFrameRateControllerClient : public cc::FrameRateControllerClient {
  public:
   FakeFrameRateControllerClient() { Reset(); }
 
-  void Reset() { began_frame_ = false; }
-  bool BeganFrame() const { return began_frame_; }
+  void Reset() { frame_count_ = 0; }
+  bool BeganFrame() const { return frame_count_ > 0; }
+  int frame_count() const { return frame_count_; }
 
   virtual void FrameRateControllerTick(
       bool throttled, const BeginFrameArgs& args) OVERRIDE {
-    began_frame_ = !throttled;
+    frame_count_ += throttled ? 0 : 1;
   }
 
  protected:
-  bool began_frame_;
+  int frame_count_;
 };
 
 TEST(FrameRateControllerTest, TestFrameThrottling_ImmediateAck) {
   scoped_refptr<base::TestSimpleTaskRunner> task_runner =
       new base::TestSimpleTaskRunner;
   FakeFrameRateControllerClient client;
   base::TimeDelta interval = base::TimeDelta::FromMicroseconds(
       base::Time::kMicrosecondsPerSecond / 60);
   scoped_refptr<FakeDelayBasedTimeSource> time_source =
       FakeDelayBasedTimeSource::Create(interval, task_runner.get());
@@ skipping 137 matching lines @@
   // receive a DidSwapBuffersComplete anyway.
   EXPECT_FALSE(task_runner->HasPendingTask());
 
   // DidSwapBuffersComplete triggers a frame, make sure the BeginFrame
   // callback is called
   controller.DidSwapBuffersComplete();
   task_runner->RunPendingTasks();
   EXPECT_TRUE(client.BeganFrame());
 }
 
+TEST(FrameRateControllerTest, TestFrameThrottling_NoDoubleTicking) {
+  scoped_refptr<base::TestSimpleTaskRunner> task_runner =
+      new base::TestSimpleTaskRunner;
+  FakeFrameRateControllerClient client;
+  FrameRateController controller(task_runner.get());
+  controller.SetClient(&client);
+
+  // SetActive triggers 1st frame and queues another tick task since the time
+  // source isn't throttling.
+  controller.SetActive(true);
+  task_runner->RunPendingTasks();
+  EXPECT_TRUE(client.BeganFrame());
+  client.Reset();
+  EXPECT_TRUE(task_runner->HasPendingTask());
+
+  // Simulate a frame swap. This shouldn't queue a second tick task.
+  controller.DidSwapBuffers();
+  controller.DidSwapBuffersComplete();
+
+  // The client should only be ticked once.
+  task_runner->RunPendingTasks();
+  EXPECT_EQ(1, client.frame_count());
+}
+
 }  // namespace
 }  // namespace cc