Fix various problems with work area change notifications so that we now (hope...

chrome/views/widget/widget_win.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_VIEWS_WIDGET_WIDGET_WIN_H_
 #define CHROME_VIEWS_WIDGET_WIDGET_WIN_H_
 
 #include <atlbase.h>
 #include <atlcrack.h>
 
@@ skipping 439 matching lines @@
     SetMsgHandled(FALSE);
     return 0;
   }
   virtual void OnSettingChange(UINT flags, const wchar_t* section);
   virtual void OnSize(UINT param, const CSize& size);
   virtual void OnSysCommand(UINT notification_code, CPoint click) { }
   virtual void OnThemeChanged();
   virtual void OnVScroll(int scroll_type, short position, HWND scrollbar) {
     SetMsgHandled(FALSE);
   }
-  virtual void OnWindowPosChanging(WINDOWPOS* window_pos) {
-    SetMsgHandled(FALSE);
-  }
+  virtual void OnWindowPosChanging(WINDOWPOS* window_pos);
   virtual void OnWindowPosChanged(WINDOWPOS* window_pos) {
     SetMsgHandled(FALSE);
   }
 
   // deletes this window as it is destroyed, override to provide different
   // behavior.
   virtual void OnFinalMessage(HWND window);
 
   // Start tracking all mouse events so that this window gets sent mouse leave
   // messages too. |is_nonclient| is true when we should track WM_NCMOUSELEAVE
   // messages instead of WM_MOUSELEAVE ones.
   void TrackMouseEvents(DWORD mouse_tracking_flags);
 
   // Actually handle mouse events. These functions are called by subclasses who
   // override the message handlers above to do the actual real work of handling
   // the event in the View system.
   bool ProcessMousePressed(const CPoint& point,
                            UINT flags,
                            bool dbl_click,
                            bool non_client);
   void ProcessMouseDragged(const CPoint& point, UINT flags);
   void ProcessMouseReleased(const CPoint& point, UINT flags);
   void ProcessMouseMoved(const CPoint& point, UINT flags, bool is_nonclient);
   void ProcessMouseExited();
 
-  // Makes sure the window still fits on screen after a settings change message
-  // from the OS, e.g. a screen resolution change.
-  virtual void AdjustWindowToFitScreenSize();
-
   // Handles re-laying out content in response to a window size change.
   virtual void ChangeSize(UINT size_param, const CSize& size);
 
   // Returns whether capture should be released on mouse release. The default
   // is true.
   virtual bool ReleaseCaptureOnMouseReleased() { return true; }
 
   enum FrameAction {FA_NONE = 0, FA_RESIZING, FA_MOVING, FA_FORWARDING};
 
   virtual RootView* CreateRootView();
@@ skipping 34 matching lines @@
   // The windows procedure used by all WidgetWins.
   static LRESULT CALLBACK WndProc(HWND window,
                                   UINT message,
                                   WPARAM w_param,
                                   LPARAM l_param);
 
   // Gets the window class name to use when creating the corresponding HWND.
   // If necessary, this registers the window class.
   std::wstring GetWindowClassName();
 
+  // Stops ignoring SetWindowPos() requests (see below).
+  void StopIgnoringPosChanges() { ignore_window_pos_changes_ = false; }
+
   // The following factory is used for calls to close the WidgetWin
   // instance.
   ScopedRunnableMethodFactory<WidgetWin> close_widget_factory_;
 
+  // The following factory is used to ignore SetWindowPos() calls for short time
+  // periods.
+  ScopedRunnableMethodFactory<WidgetWin> ignore_pos_changes_factory_;
+
   // The flags currently being used with TrackMouseEvent to track mouse
   // messages. 0 if there is no active tracking. The value of this member is
   // used when tracking is canceled.
   DWORD active_mouse_tracking_flags_;
 
   // Whether or not this is a top level window.
   bool toplevel_;
 
   bool opaque_;
 
@@ skipping 44 matching lines @@
 
   // Coordinates of the last mouse move event, in screen coordinates.
   int last_mouse_move_x_;
   int last_mouse_move_y_;
 
   // Instance of accessibility information and handling for MSAA root
   CComPtr<IAccessible> accessibility_root_;
 
   // Our hwnd.
   HWND hwnd_;
+
+  // The last-seen monitor containing us, and its work area.  These are used to
+  // catch updates to the work area and react accordingly.
+  HMONITOR last_monitor_;
+  gfx::Rect last_work_area_;
+
+  // When true, this flag makes us discard incoming SetWindowPos() requests that
+  // only change our position/size.  (We still allow changes to Z-order,
+  // activation, etc.)
+  bool ignore_window_pos_changes_;
 };
 
 }  // namespace views
 
 #endif  // #ifndef CHROME_VIEWS_WIDGET_WIDGET_WIN_H_