Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 67023: Fix various problems with work area change notifications so that we now (hope... (Closed)

Created:
11 years, 8 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix various problems with work area change notifications so that we now (hopefully) move/resize correctly whenever the work area changes, no matter why. BUG=8873 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13533

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -38 lines) Patch
M chrome/views/widget/widget_win.h View 4 chunks +18 lines, -7 lines 0 comments Download
M chrome/views/widget/widget_win.cc View 7 chunks +95 lines, -31 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
11 years, 8 months ago (2009-04-09 22:53:20 UTC) #1
Ben Goodger (Google)
evil. OK. http://codereview.chromium.org/67023/diff/1/2 File chrome/views/widget/widget_win.cc (right): http://codereview.chromium.org/67023/diff/1/2#newcode722 Line 722: } else if (toplevel_) { Can ...
11 years, 8 months ago (2009-04-10 19:59:03 UTC) #2
Peter Kasting
11 years, 8 months ago (2009-04-10 20:05:02 UTC) #3
http://codereview.chromium.org/67023/diff/1/2
File chrome/views/widget/widget_win.cc (right):

http://codereview.chromium.org/67023/diff/1/2#newcode722
Line 722: } else if (toplevel_) {
On 2009/04/10 19:59:03, Ben Goodger wrote:
> Can you just use !GetParent() here instead?

Yep, and I can just remove toplevel_ entirely, going one better than merely
commenting it :)

Powered by Google App Engine
This is Rietveld 408576698