Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 670183002: explicitly size fType in SkRRect, to ensure the are no uninitialized bytes (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

explicitly size fType in SkRRect, to ensure the are no uninitialized bytes (so it can be used as a key in a cache) BUG=skia: Committed: https://skia.googlesource.com/skia/+/727b8c1d1c0ba0634a97bff601e7af96bfd7daf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M include/core/SkRRect.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
6 years, 2 months ago (2014-10-22 18:14:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670183002/1
6 years, 2 months ago (2014-10-22 18:15:04 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-22 18:15:05 UTC) #5
robertphillips
lgtm
6 years, 2 months ago (2014-10-22 18:18:59 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:24:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 727b8c1d1c0ba0634a97bff601e7af96bfd7daf8

Powered by Google App Engine
This is Rietveld 408576698