Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: webkit/glue/webwidget_delegate.h

Issue 67018: Chrome side of the WebKit popup changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/webwidget_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webwidget_delegate.h
===================================================================
--- webkit/glue/webwidget_delegate.h (revision 13487)
+++ webkit/glue/webwidget_delegate.h (working copy)
@@ -21,7 +21,7 @@
class WebCursor;
struct WebPluginGeometry;
-struct MenuItem {
+struct WebMenuItem {
// Container for information about entries in an HTML select popup menu.
// Types must be kept in sync with PopupListBox::ListItemType in
// WebCore/platform/chromium/PopupMenuChromium.h. This won't change often
@@ -57,21 +57,20 @@
// window should be displayed, but generally only means something for WebViews.
virtual void Show(WebWidget* webwidget, WindowOpenDisposition disposition) = 0;
- // Used for displaying HTML select elements as popup menus on Mac OS X (other
- // platforms will use Show() above). |bounds| represents the positioning on
- // the screen (in WebKit coordinates, origin at the top left corner) of the
- // button that will display the menu. It will be used, along with
- // |item_height| (which refers to the size of each entry in the menu), to
- // position the menu on the screen. |selected_index| indicates the menu item
- // that should be drawn as selected when the menu initially is displayed.
- // |items| contains information about each of the entries in the popup menu,
- // such as the type (separator, option, group), the text representation and
- // the item's enabled status.
- virtual void ShowWithItems(WebWidget* webwidget,
- const WebKit::WebRect& bounds,
- int item_height,
- int selected_index,
- const std::vector<MenuItem>& items) = 0;
+ // Used for displaying HTML popup menus on Mac OS X (other platforms will use
+ // Show() above). |bounds| represents the positioning on the screen (in WebKit
+ // coordinates, origin at the top left corner) of the button that will display
+ // the menu. It will be used, along with |item_height| (which refers to the
+ // size of each entry in the menu), to position the menu on the screen.
+ // |selected_index| indicates the menu item that should be drawn as selected
+ // when the menu initially is displayed. |items| contains information about
+ // each of the entries in the popup menu, such as the type (separator, option,
+ // group), the text representation and the item's enabled status.
+ virtual void ShowAsPopupWithItems(WebWidget* webwidget,
+ const WebKit::WebRect& bounds,
+ int item_height,
+ int selected_index,
+ const std::vector<WebMenuItem>& items) = 0;
// This method is called to instruct the window containing the WebWidget to
// close. Note: This method should just be the trigger that causes the
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/webwidget_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698