Issue 67018: Chrome side of the WebKit popup changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67018: Chrome side of the WebKit popup changes. (Closed)

Created:
11 years, 8 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Chrome side of the WebKit popup changes. Implements HTML select popups on Mac OS X as native Cocoa controls. BUG=5095 (http://crbug.com/5095) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13495

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -90 lines)			Patch
M	chrome/renderer/render_widget.h	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/renderer/render_widget.cc	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	webkit/glue/chrome_client_impl.h	View	1 2	2 chunks	+6 lines, -8 lines	0 comments	Download
M	webkit/glue/chrome_client_impl.cc	View	1 2	3 chunks	+27 lines, -26 lines	0 comments	Download
M	webkit/glue/webwidget_delegate.h	View	1 2	2 chunks	+15 lines, -16 lines	0 comments	Download
M	webkit/glue/webwidget_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webwidget_impl.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_webview_delegate.mm	View	1 2	4 chunks	+10 lines, -8 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_gtk.cc	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_win.cc	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Paul Godavari

(This depends on http://codereview.chromium.org/67017 and a DEPS change).

11 years, 8 months ago (2009-04-09 22:41:14 UTC) #1

LGTM