Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 670173002: Fix webrequest api for webview in webui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename EmbedderDestroyed to EmbedderWillBeDestroyed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index 2fbbf603020c336a136e2271ac121090f84d6d1e..d07d72e08947c4efbb03b1cd9109233765b17664 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -91,9 +91,10 @@ class GuestViewBase::EmbedderLifetimeObserver : public WebContentsObserver {
void Destroy() {
if (destroyed_)
return;
+ guest_->EmbedderWillBeDestroyed();
+
destroyed_ = true;
guest_->embedder_web_contents_ = NULL;
Fady Samuel 2014/10/22 21:20:53 Super nit: move guest_->EmbedderWillBeDestroyed()
guohui 2014/10/23 13:40:52 Done.
- guest_->EmbedderDestroyed();
guest_->Destroy();
}
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698