Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 670173002: Fix webrequest api for webview in webui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index 2fbbf603020c336a136e2271ac121090f84d6d1e..0ec0d61878d1d404f88dceea9346cb4d8c1f8bbb 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -75,6 +75,10 @@ class GuestViewBase::EmbedderLifetimeObserver : public WebContentsObserver {
void AboutToNavigateRenderView(
content::RenderViewHost* render_view_host) override {
+ if (destroyed_)
+ return;
+
+ guest_->WillDetachFromEmbedder();
Fady Samuel 2014/10/22 16:43:20 I think guest_->EmbedderDestroyed() already does w
guohui 2014/10/22 18:46:06 EmbedderDestroyed() is executed after embedder_web
// If the embedder navigates then destroy the guest.
Destroy();
}

Powered by Google App Engine
This is Rietveld 408576698