DevTools: [CodeMirrro] defer autocomplete controller initialization

Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1972 matching lines @@
 WebInspector.CodeMirrorTextEditor.AutocompleteController = function(textEditor, codeMirror, dictionary)
 {
     this._textEditor = textEditor;
     this._codeMirror = codeMirror;
 
     this._onScroll = this._onScroll.bind(this);
     this._onCursorActivity = this._onCursorActivity.bind(this);
     this._changes = this._changes.bind(this);
     this._beforeChange = this._beforeChange.bind(this);
     this._blur = this._blur.bind(this);
-    this._codeMirror.on("scroll", this._onScroll);
-    this._codeMirror.on("cursorActivity", this._onCursorActivity);
+
     this._codeMirror.on("changes", this._changes);
-    this._codeMirror.on("beforeChange", this._beforeChange);
-    this._codeMirror.on("blur", this._blur);
 
     this._additionalWordChars = WebInspector.CodeMirrorTextEditor._NoAdditionalWordChars;
     this._enabled = true;
 
     this._dictionary = dictionary;
-    this._addTextToCompletionDictionary(this._textEditor.text());
+    this._initialized = false;
 }
 
 WebInspector.CodeMirrorTextEditor.AutocompleteController.Dummy = new WebInspector.CodeMirrorTextEditor.DummyAutocompleteController();
 WebInspector.CodeMirrorTextEditor._NoAdditionalWordChars = {};
 WebInspector.CodeMirrorTextEditor._CSSAdditionalWordChars = { ".": true, "-": true };
 
 WebInspector.CodeMirrorTextEditor.AutocompleteController.prototype = {
+    _initializeIfNeeded: function()
+    {
+        if (this._initialized)
+            return;
+        this._initialized = true;
+        this._codeMirror.on("scroll", this._onScroll);
+        this._codeMirror.on("cursorActivity", this._onCursorActivity);
+        this._codeMirror.on("beforeChange", this._beforeChange);
+        this._codeMirror.on("blur", this._blur);
+        this._addTextToCompletionDictionary(this._textEditor.text());
+    },
+
     dispose: function()
     {
+        this._codeMirror.off("changes", this._changes);
+        if (!this._initialized)
+            return;
         this._codeMirror.off("scroll", this._onScroll);
         this._codeMirror.off("cursorActivity", this._onCursorActivity);
-        this._codeMirror.off("changes", this._changes);
         this._codeMirror.off("beforeChange", this._beforeChange);
         this._codeMirror.off("blur", this._blur);
     },
 
     /**
      * @param {boolean} enabled
      */
     setEnabled: function(enabled)
     {
         if (enabled === this._enabled)
@@ skipping 34 matching lines @@
     _shouldProcessWordForAutocompletion: function(word)
     {
         return !!word.length && (word[0] < '0' || word[0] > '9');
     },
 
     /**
      * @param {string} text
      */
     _addTextToCompletionDictionary: function(text)
     {
-        if (!this._enabled)
+        if (!this._enabled || !this._initialized)
             return;
         var words = WebInspector.TextUtils.textToWords(text, this._isWordChar.bind(this));
         for (var i = 0; i < words.length; ++i) {
             if (this._shouldProcessWordForAutocompletion(words[i]))
                 this._dictionary.addWord(words[i]);
         }
     },
 
     /**
      * @param {string} text
      */
     _removeTextFromCompletionDictionary: function(text)
     {
-        if (!this._enabled)
+        if (!this._enabled || !this._initialized)
             return;
         var words = WebInspector.TextUtils.textToWords(text, this._isWordChar.bind(this));
         for (var i = 0; i < words.length; ++i) {
             if (this._shouldProcessWordForAutocompletion(words[i]))
                 this._dictionary.removeWord(words[i]);
         }
     },
 
     /**
      * @param {!CodeMirror} codeMirror
@@ skipping 70 matching lines @@
                 return false;
             var context = this._textEditor.copyRange(wordRange);
             if (context !== mainSelectionContext)
                 return false;
         }
         return true;
     },
 
     autocomplete: function()
     {
+        this._initializeIfNeeded();
         var dictionary = this._dictionary;
         if (this._codeMirror.somethingSelected()) {
             this.finishAutocomplete();
             return;
         }
 
         var selections = this._codeMirror.listSelections().slice();
         var topSelection = selections.shift();
         var cursor = topSelection.head;
         var substituteRange = this._autocompleteWordRange(cursor.line, cursor.ch);
@@ skipping 286 matching lines @@
     function tokenOverride(superToken, stream, state)
     {
         var token = superToken(stream, state);
         return token ? tokenPrefix + token.split(/ +/).join(" " + tokenPrefix) : token;
     }
 }
 
 WebInspector.CodeMirrorTextEditor._overrideModeWithPrefixedTokens("css", "css-");
 WebInspector.CodeMirrorTextEditor._overrideModeWithPrefixedTokens("javascript", "js-");
 WebInspector.CodeMirrorTextEditor._overrideModeWithPrefixedTokens("xml", "xml-");