Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 670163002: DevTools: [CodeMirrro] defer autocomplete controller initialization (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [CodeMirrro] defer autocomplete controller initialization Autocompletion controller intialization makes almost half of the time of SourceFrame initialization. In order to render editor as fast as possible, this patch defers autocompletion initialization until the first need. BUG=425550 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184263 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184512

Patch Set 1 #

Patch Set 2 : fix testcase #

Patch Set 3 : fix regression #

Patch Set 4 : add testcase #

Patch Set 5 : rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -8 lines) Patch
M LayoutTests/inspector/editor/text-editor-autocomplete.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/inspector/editor/text-editor-autocomplete-expected.txt View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 2 3 4 5 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
lushnikov
PTAL
6 years, 2 months ago (2014-10-22 14:46:09 UTC) #1
vsevik
lgtm
6 years, 2 months ago (2014-10-22 14:48:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670163002/1
6 years, 2 months ago (2014-10-22 14:49:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/30439)
6 years, 2 months ago (2014-10-22 15:50:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670163002/20001
6 years, 2 months ago (2014-10-23 11:42:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 184263
6 years, 2 months ago (2014-10-23 12:49:35 UTC) #9
vsevik
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/676393003/ by vsevik@chromium.org. ...
6 years, 1 month ago (2014-10-27 14:44:33 UTC) #10
lushnikov
Please, take a look
6 years, 1 month ago (2014-10-28 10:29:27 UTC) #11
vsevik
lgtm
6 years, 1 month ago (2014-10-28 11:17:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670163002/80001
6 years, 1 month ago (2014-10-28 11:18:05 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 12:33:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 184512

Powered by Google App Engine
This is Rietveld 408576698