Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 670143002: Removing dead code in WebViewImpl.h (Closed)

Created:
6 years, 2 months ago by patro
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing dead code in WebViewImpl.h In patch https://codereview.chromium.org/263853008 WebViewImpl::resetSavedScrollAndScaleState() function definition was removed but not function declaration. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
patro
Kindly Review Thanks Shyam Patro
6 years, 2 months ago (2014-10-22 12:13:31 UTC) #2
Mike West
LGTM.
6 years, 2 months ago (2014-10-22 12:26:48 UTC) #4
Mike West
Nit: s/deadcode/dead code/ in the CL description.
6 years, 2 months ago (2014-10-22 12:27:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670143002/1
6 years, 2 months ago (2014-10-22 12:57:28 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 14:07:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184183

Powered by Google App Engine
This is Rietveld 408576698