DevTools: open context menu in the embedder even when no custom items are there.

DevTools: open context menu in the embedder even when no custom items are there.

BUG=424171
R=dgozman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184168

[pfeldman, 2014-10-22 08:24:47]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2014-10-22 08:26:10]

lgtm

[pfeldman, 2014-10-22 08:37:48]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-10-22 08:38:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/670123002/1

[commit-bot: I haz the power, 2014-10-22 09:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 09:45:42]

Failed to apply patch for Source/devtools/front_end/ui/ContextMenu.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/ui/ContextMenu.js
  Hunk #1 FAILED at 290.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/devtools/front_end/ui/ContextMenu.js.rej

Patch:       Source/devtools/front_end/ui/ContextMenu.js
Index: Source/devtools/front_end/ui/ContextMenu.js
diff --git a/Source/devtools/front_end/ui/ContextMenu.js
b/Source/devtools/front_end/ui/ContextMenu.js
index
dd2efc3e4c4698d01e81759d3dd7aa9cafd4b89f..4b6353704dadd657d8cb37fd04284b4b9c832273
100644
--- a/Source/devtools/front_end/ui/ContextMenu.js
+++ b/Source/devtools/front_end/ui/ContextMenu.js
@@ -290,16 +290,14 @@ WebInspector.ContextMenu.prototype = {
     {
         var menuObject = this._buildDescriptor();
 
-        if (menuObject.length) {
-            WebInspector._contextMenu = this;
-            if (WebInspector.ContextMenu._useSoftMenu ||
InspectorFrontendHost.isHostedMode()) {
-                var softMenu = new WebInspector.SoftContextMenu(menuObject,
this._itemSelected.bind(this));
-                softMenu.show(this._x, this._y);
-            } else {
-                InspectorFrontendHost.showContextMenuAtPoint(this._x, this._y,
menuObject);
-               
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.ContextMenuCleared,
this._menuCleared, this);
-               
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.ContextMenuItemSelected,
this._onItemSelected, this);
-            }
+        WebInspector._contextMenu = this;
+        if (WebInspector.ContextMenu._useSoftMenu ||
InspectorFrontendHost.isHostedMode()) {
+            var softMenu = new WebInspector.SoftContextMenu(menuObject,
this._itemSelected.bind(this));
+            softMenu.show(this._x, this._y);
+        } else {
+            InspectorFrontendHost.showContextMenuAtPoint(this._x, this._y,
menuObject);
+           
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.ContextMenuCleared,
this._menuCleared, this);
+           
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.ContextMenuItemSelected,
this._onItemSelected, this);
         }
     },

[commit-bot: I haz the power, 2014-10-22 09:45:58]

The CQ bit was unchecked by commit-bot@chromium.org

[pfeldman, 2014-10-22 11:15:03]

Committed patchset #3 (id:40001) manually as 184168 (presubmit successful).