Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 670123002: DevTools: open context menu in the embedder even when no custom items are there. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: open context menu in the embedder even when no custom items are there. BUG=424171 R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184168

Patch Set 1 #

Patch Set 2 : rebaselined #

Patch Set 3 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M Source/devtools/front_end/ui/ContextMenu.js View 1 2 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pfeldman
6 years, 2 months ago (2014-10-22 08:24:47 UTC) #2
dgozman
lgtm
6 years, 2 months ago (2014-10-22 08:26:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670123002/1
6 years, 2 months ago (2014-10-22 08:38:22 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/ui/ContextMenu.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-22 09:45:42 UTC) #7
pfeldman
6 years, 2 months ago (2014-10-22 11:15:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 184168 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698